bitstream/fuel-alert
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: guard malformed postcodes.io responses and isolate persist errors from HTTP success

Browse Source
This commit is contained in:
Ovidiu U
2026-04-22 12:22:15 +01:00
parent 45bf1c0d24
commit d460de1850
1 changed files with 37 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/Services/PostcodeService.php
View File

@@ -122,6 +122,10 @@ class PostcodeService
$data = $response->json('result'); $data = $response->json('result');
if (! is_array($data) || ! isset($data['postcode'], $data['latitude'], $data['longitude'])) {
return null;
}
$result = new LocationResult( $result = new LocationResult(
query: $postcode, query: $postcode,
displayName: $data['postcode'], displayName: $data['postcode'],
@@ -129,6 +133,7 @@ class PostcodeService
lng: $data['longitude'], lng: $data['longitude'],
); );
try {
Postcode::updateOrCreate( Postcode::updateOrCreate(
['postcode' => $normalised], ['postcode' => $normalised],
[ [
@@ -137,6 +142,12 @@ class PostcodeService
'lng' => $data['longitude'], 'lng' => $data['longitude'],
], ],
); );
} catch (Throwable $e) {
Log::warning('PostcodeService: failed to persist postcode after HTTP fallback', [
'postcode' => $normalised,
'error' => $e->getMessage(),
]);
}
return $result; return $result;
} catch (Throwable $e) { } catch (Throwable $e) {
@@ -163,6 +174,10 @@ class PostcodeService
$data = $response->json('result'); $data = $response->json('result');
if (! is_array($data) || ! isset($data['outcode'], $data['latitude'], $data['longitude'])) {
return null;
}
$result = new LocationResult( $result = new LocationResult(
query: $outcode, query: $outcode,
displayName: $data['outcode'], displayName: $data['outcode'],
@@ -170,6 +185,7 @@ class PostcodeService
lng: $data['longitude'], lng: $data['longitude'],
); );
try {
Outcode::updateOrCreate( Outcode::updateOrCreate(
['outcode' => $normalised], ['outcode' => $normalised],
[ [
@@ -177,6 +193,12 @@ class PostcodeService
'lng' => $data['longitude'], 'lng' => $data['longitude'],
], ],
); );
} catch (Throwable $e) {
Log::warning('PostcodeService: failed to persist outcode after HTTP fallback', [
'outcode' => $normalised,
'error' => $e->getMessage(),
]);
}
return $result; return $result;
} catch (Throwable $e) { } catch (Throwable $e) {