refactor: split oil price ingestion and prediction into separate services + commands

- BrentPriceFetcher owns ingestion (fetchFromEia / fetchFromFred, each throws on failure) - BrentPricePredictor owns prediction and marks latest brent_prices row as generated - oil:fetch command tries EIA, falls back to FRED, fails loudly if both fail - oil:predict command prompts if latest price already has a prediction; --force bypasses - add prediction_generated_at column to brent_prices - delete OilPriceService (replaced by the two focused services)
2026-04-14 16:59:43 +01:00
parent 1a0381265e
commit 486f0e689c
10 changed files with 415 additions and 306 deletions
--- a/tests/Unit/Services/BrentPriceFetcherTest.php
+++ b/tests/Unit/Services/BrentPriceFetcherTest.php
@@ -0,0 +1,120 @@
+<?php
+
+use App\Models\BrentPrice;
+use App\Services\ApiLogger;
+use App\Services\BrentPriceFetcher;
+use App\Services\BrentPriceSources\BrentPriceFetchException;
+use App\Services\BrentPriceSources\EiaBrentPriceSource;
+use App\Services\BrentPriceSources\FredBrentPriceSource;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Http;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function (): void {
+    Http::preventStrayRequests();
+    $apiLogger = new ApiLogger;
+    $this->fetcher = new BrentPriceFetcher(
+        new EiaBrentPriceSource($apiLogger),
+        new FredBrentPriceSource($apiLogger),
+    );
+});
+
+it('fetches and stores brent prices from EIA', function (): void {
+    Http::fake([
+        '*eia.gov/*' => Http::response([
+            'response' => [
+                'data' => [
+                    ['period' => '2026-04-02', 'value' => '73.80'],
+                    ['period' => '2026-04-01', 'value' => '75.10'],
+                ],
+            ],
+        ]),
+    ]);
+
+    $this->fetcher->fetchFromEia();
+
+    expect(BrentPrice::count())->toBe(2)
+        ->and(BrentPrice::find('2026-04-02')->price_usd)->toBe('73.80');
+});
+
+it('throws when EIA returns a 500', function (): void {
+    Http::fake(['*eia.gov/*' => Http::response([], 500)]);
+
+    $this->fetcher->fetchFromEia();
+})->throws(BrentPriceFetchException::class);
+
+it('throws when EIA returns empty data', function (): void {
+    Http::fake(['*eia.gov/*' => Http::response(['response' => ['data' => []]])]);
+
+    $this->fetcher->fetchFromEia();
+})->throws(BrentPriceFetchException::class);
+
+it('filters out EIA missing value markers', function (): void {
+    Http::fake([
+        '*eia.gov/*' => Http::response([
+            'response' => [
+                'data' => [
+                    ['period' => '2026-04-01', 'value' => '75.10'],
+                    ['period' => '2026-04-02', 'value' => '.'],
+                    ['period' => '2026-04-03', 'value' => '74.20'],
+                ],
+            ],
+        ]),
+    ]);
+
+    $this->fetcher->fetchFromEia();
+
+    expect(BrentPrice::count())->toBe(2)
+        ->and(BrentPrice::find('2026-04-02'))->toBeNull();
+});
+
+it('fetches and stores brent prices from FRED', function (): void {
+    Http::fake([
+        '*/fred/series/observations*' => Http::response([
+            'observations' => [
+                ['date' => '2026-04-01', 'value' => '75.10'],
+                ['date' => '2026-04-02', 'value' => '73.80'],
+            ],
+        ]),
+    ]);
+
+    $this->fetcher->fetchFromFred();
+
+    expect(BrentPrice::count())->toBe(2);
+});
+
+it('throws when FRED fails', function (): void {
+    Http::fake(['*/fred/series/observations*' => Http::response([], 500)]);
+
+    $this->fetcher->fetchFromFred();
+})->throws(BrentPriceFetchException::class);
+
+it('filters out FRED missing value markers', function (): void {
+    Http::fake([
+        '*/fred/series/observations*' => Http::response([
+            'observations' => [
+                ['date' => '2026-04-01', 'value' => '75.10'],
+                ['date' => '2026-04-02', 'value' => '.'],
+            ],
+        ]),
+    ]);
+
+    $this->fetcher->fetchFromFred();
+
+    expect(BrentPrice::count())->toBe(1);
+});
+
+it('upserts existing rows on refetch', function (): void {
+    Http::fake([
+        '*eia.gov/*' => Http::sequence()
+            ->push(['response' => ['data' => [['period' => '2026-04-01', 'value' => '74.00']]]])
+            ->push(['response' => ['data' => [['period' => '2026-04-01', 'value' => '75.50']]]]),
+    ]);
+
+    $this->fetcher->fetchFromEia();
+    $this->fetcher->fetchFromEia();
+
+    expect(BrentPrice::count())->toBe(1)
+        ->and(BrentPrice::find('2026-04-01')->price_usd)->toBe('75.50');
+});